Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording rules #1055

Merged
merged 20 commits into from
Mar 7, 2024
Merged

Fix recording rules #1055

merged 20 commits into from
Mar 7, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: giantswarm/roadmap#3157

This PR fixes some recording rules to add the cluster_id and cluster_type on all aggregations and on

Checklist

QuentinBisson and others added 16 commits March 5, 2024 16:04
@QuentinBisson QuentinBisson self-assigned this Mar 5, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner March 5, 2024 20:37
@QuentinBisson QuentinBisson merged commit a8be2b1 into master Mar 7, 2024
6 checks passed
@QuentinBisson QuentinBisson deleted the fix-recording-rules branch March 7, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants