Add mimir enabled flag #1053
Merged
Add mimir enabled flag #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervenicol
reviewed
Mar 5, 2024
helm/prometheus-rules/templates/alerting-rules/aws.management-cluster.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/aws.workload-cluster.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/bastions.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/cluster-service.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/crsync.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/kvm.management-cluster.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/kvm.workload-cluster.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/managed-logging.rules.yml
Outdated
Show resolved
Hide resolved
helm/prometheus-rules/templates/alerting-rules/release.rules.yml
Outdated
Show resolved
Hide resolved
hervenicol
reviewed
Mar 5, 2024
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: PrometheusRule | ||
| metadata: | ||
| creationTimestamp: null | ||
| labels: | ||
| {{- include "labels.common" . | nindent 4 }} | ||
| {{- if not .Values.mimir.enabled }} |
There was a problem hiding this comment.
This file is only for vintage clusters; I guess we don't need the condition then?
There was a problem hiding this comment.
Well that's true but i'm not sure if phoenix will not add CAPI ones here
helm/prometheus-rules/templates/alerting-rules/credentiald.rules.yml
Outdated
Show resolved
Hide resolved
…cluster.rules.yml Co-authored-by: Hervé Nicol <[email protected]>
…uster.rules.yml Co-authored-by: Hervé Nicol <[email protected]>
Co-authored-by: Hervé Nicol <[email protected]>
….rules.yml Co-authored-by: Hervé Nicol <[email protected]>
Co-authored-by: Hervé Nicol <[email protected]>
…cluster.rules.yml Co-authored-by: Hervé Nicol <[email protected]>
…ules.yml Co-authored-by: Hervé Nicol <[email protected]>
Co-authored-by: Hervé Nicol <[email protected]>
…uster.rules.yml Co-authored-by: Hervé Nicol <[email protected]>
….rules.yml Co-authored-by: Hervé Nicol <[email protected]>
Co-authored-by: Hervé Nicol <[email protected]>
Co-authored-by: Hervé Nicol <[email protected]>
…es.yml Co-authored-by: Zirko <[email protected]>
hervenicol
reviewed
Mar 5, 2024
hervenicol
approved these changes
Mar 5, 2024
|
Linked in this https://github.com/giantswarm/shared-configs/pull/8 |
QuentinBisson
commented
Mar 5, 2024
helm/prometheus-rules/templates/alerting-rules/inhibit.management-cluster.rules.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: giantswarm/roadmap#3157
This PR adds the mimir.enabled flag for a preparation to mimir migration and do a whole bunch of really small fixes
Checklist
oncall-kaas-cloudGitHub group).