Fix monitoring alerts #1050
Merged
Fix monitoring alerts #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervenicol
reviewed
Mar 5, 2024
| @@ -31,7 +31,7 @@ spec: | |||
| - alert: PrometheusOperatorListErrors | |||
| annotations: | |||
| description: Errors while performing List operations in controller {{`{{`}}$labels.controller{{`}}`}} in {{`{{`}}$labels.namespace{{`}}`}} namespace. | |||
| expr: (sum by (controller,namespace) (rate(prometheus_operator_list_operations_failed_total{app="prometheus-operator",namespace="{{ .Values.namespace }}"}[10m])) / sum by (controller,namespace) (rate(prometheus_operator_list_operations_total{app="prometheus-operator",namespace="{{ .Values.namespace }}"}[10m]))) > 0.4 | |||
There was a problem hiding this comment.
Why did we have this namespace filter in the first place?
My best guess is to prevent monitoring customer operators. If that's the case, what prevents us from that now?
There was a problem hiding this comment.
2 things, first we own this app so we should technically have been notified anyway. I think we added that back in the day from mixins but we can adjust them if they page too much
There was a problem hiding this comment.
Actually I think I remember adding some similar exclusions because customer-managed operators were failing too much.
But all right, fine with me, let's try.
There was a problem hiding this comment.
oh maybe you did but still the namespace is not monitoring anymore :D
hervenicol
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: giantswarm/roadmap#3157
This PR fixes remote write and prometheus-operator alerts for mimir
Checklist
oncall-kaas-cloudGitHub group).