Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grafana and silence operator alerts for mimir #1048

Merged

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: giantswarm/roadmap#3157

This PR fixes grafana and silence-operator alerts for mimir

Checklist

@QuentinBisson QuentinBisson self-assigned this Mar 5, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner March 5, 2024 11:18
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson force-pushed the fix-grafana-and-silence-operator-alerts-for-mimir branch from 9200818 to 7da3cb3 Compare March 5, 2024 13:50
@QuentinBisson QuentinBisson force-pushed the fix-grafana-and-silence-operator-alerts-for-mimir branch from b73b10c to ccd2c2e Compare March 5, 2024 13:55
@QuentinBisson QuentinBisson merged commit 4fd5e3d into master Mar 5, 2024
5 checks passed
@QuentinBisson QuentinBisson deleted the fix-grafana-and-silence-operator-alerts-for-mimir branch March 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants