Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old alerts that are not used anymore #1035

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: giantswarm/roadmap#3157

This PR cleans up some alerts that are not needed anymore

Checklist

@QuentinBisson QuentinBisson self-assigned this Mar 1, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner March 1, 2024 17:52
@QuentinBisson QuentinBisson requested a review from a team March 1, 2024 19:32
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit a0e7482 into master Mar 4, 2024
5 checks passed
@QuentinBisson QuentinBisson deleted the clean-up-useless-rules branch March 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants