Skip to content

Commit

Permalink
Remove crsync absent deployments alerts (#1150)
Browse files Browse the repository at this point in the history
It causes false triggers because the MC where the rule is applied
has multiple prometheus instances and they all take the rule into
account, but only the operations one should have the alert.

We can get it back online when we has a single instance / mimir.
  • Loading branch information
uvegla authored Apr 30, 2024
1 parent 303e45d commit 218e53c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 30 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Removed

- Removed alerts for absent `crsync` deployments. They cause false alerts because the rules apply to all prometheus instances on the MC.

## [3.13.0] - 2024-04-30

### Added
Expand Down
30 changes: 0 additions & 30 deletions helm/prometheus-rules/templates/alerting-rules/crsync.rules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,36 +13,6 @@ spec:
groups:
- name: crsync
rules:
- alert: CrsyncDockerIoIsMissing
annotations:
description: 'CrSync deployment for docker.io is absent'
opsrecipe: crsync-deployments-missing/
expr: absent(kube_deployment_status_replicas_available{namespace="crsync", deployment="crsync-docker-io"})
for: 10m
labels:
area: kaas
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
cancel_if_outside_working_hours: "true"
severity: page
team: honeybadger
topic: releng
- alert: CrsyncGiantswarmAzureCrIoIsMissing
annotations:
description: 'CrSync deployment for giantswarm.azurecr.io is absent'
opsrecipe: crsync-deployments-missing/
expr: absent(kube_deployment_status_replicas_available{namespace="crsync", deployment="crsync-giantswarm-azurecr-io"})
for: 10m
labels:
area: kaas
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
cancel_if_outside_working_hours: "true"
severity: page
team: honeybadger
topic: releng
- alert: CrsyncDeploymentNotSatisfied
annotations:
description: '{{`CrSync deployment {{ $labels.deployment }} is not satisfied in {{ $labels.installation }} / {{ $labels.cluster_id }} at the {{ $labels.namespace }} namespace.`}}'
Expand Down

0 comments on commit 218e53c

Please sign in to comment.