Ignore prometheus-agent-config-if-mimir-enabled #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
commented
Apr 9, 2024
| var remoteWriteConfigResource resource.Interface | ||
| { | ||
| if config.MimirEnabled { | ||
| remoteWriteConfigResource = noop.New(noop.Config{Logger: config.Logger}) |
There was a problem hiding this comment.
Replaces the resources with a noop resource
QuentinBisson
force-pushed
the
ignore-prometheus-agent-config-if-mimir-enabled
branch
2 times, most recently
from
512fa75 to
6d354e0
Compare
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
ignore-prometheus-agent-config-if-mimir-enabled
branch
from
6d354e0 to
3d35357
Compare
marieroque
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR stops reconciling prometheus agent configuration files which are now reconciled by giantswarm/observability-operator#10 so we can more easily play with tenancy and mimir. This also removes the vintage complexity :D
I have:
CHANGELOG.md