Remove alerting from Prometheus if mimir is enabled #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
remove-alerting-from-prometheus-if-mimir-is-enabled
branch
from
2cb3023 to
1bfda39
Compare
QuentinBisson
commented
Mar 12, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/giantswarm/prometheus-meta-operator/v2 | |||
|
|
|||
| go 1.22.1 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
I cannot run this otherwise because fedora only has up to go 1.22.0
QuentinBisson
commented
Mar 12, 2024
| { | ||
| // This resource creates a static secret to connect Prometheus to Alertmanager. When using mimir, this is not needed anymore | ||
| if config.MimirEnabled { | ||
| alertmanagerWiringResource = &noop.Resource{} |
There was a problem hiding this comment.
Adding a noop operation to not create useless secret in mimir backed installations
QuentinBisson
commented
Mar 12, 2024
| prometheus := &promv1.Prometheus{ | ||
| ObjectMeta: objectMeta, | ||
| Spec: promv1.PrometheusSpec{ | ||
| // We need to use this to connect each WC prometheus with the central alertmanager instead of the alerting section of the Prometheus CR |
There was a problem hiding this comment.
Moved at the bottom only if mimir is not enabled
marieroque
approved these changes
Mar 12, 2024
QuentinBisson
deleted the
remove-alerting-from-prometheus-if-mimir-is-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3160
This PR removes alerting from prometheus to alertmanager if mimir is enabled to avoid duplicate alerts.
Alerting will keep working thanks to https://github.com/giantswarm/shared-configs/commit/bcd2f81fe326c06d7cd3f076006e3d642d866fa6
Checklist
I have:
CHANGELOG.md