Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hearbeat for Mimir #6

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add a hearbeat for Mimir #6

merged 2 commits into from
Apr 8, 2024

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it

This PR initialize the monitoring controller and create one heartbeat per installation

Checklist

  • Update changelog in CHANGELOG.md.

@QuentinBisson QuentinBisson self-assigned this Apr 2, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner April 2, 2024 21:35
@QuentinBisson QuentinBisson force-pushed the add-heartbeat-creation branch 3 times, most recently from 621513b to 77fbe5f Compare April 2, 2024 21:57
@QuentinBisson QuentinBisson changed the title add-mimir-heartbeat A a hearbeat for Mimir Apr 2, 2024
@QuentinBisson QuentinBisson changed the title A a hearbeat for Mimir Add a hearbeat for Mimir Apr 2, 2024
@QuentinBisson QuentinBisson force-pushed the add-heartbeat-creation branch 3 times, most recently from 46754e8 to 388f5d2 Compare April 2, 2024 22:49
@QuentinBisson QuentinBisson force-pushed the add-heartbeat-creation branch from 388f5d2 to bf391a6 Compare April 2, 2024 23:11
@QuentinBisson
Copy link
Contributor Author

image
image

@QuentinBisson
Copy link
Contributor Author

@QuantumEnigmaa do you want to pair on the review tomorrow so you learn a bit of go? Or was it straightforward enough?

@QuantumEnigmaa
Copy link
Contributor

I'd love to :)

@QuentinBisson
Copy link
Contributor Author

Then let's wait tomorrow :)

@QuentinBisson QuentinBisson merged commit e80796a into main Apr 8, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the add-heartbeat-creation branch April 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants