fix finalizer removal #31
Conversation
| @@ -189,14 +189,13 @@ func (pas PrometheusAgentService) deleteConfigMap(ctx context.Context, cluster * | |||
| } | |||
|
|
|||
| // Delete the finalizer | |||
| desired := current.DeepCopy() | |||
There was a problem hiding this comment.
How does removing the DeepCopy fixes the finalizer removal /
There was a problem hiding this comment.
Deepcopy is useless if we are updating instead of patching
There was a problem hiding this comment.
In both case DeepCopy should not be needed, since the object is local to the function.
But how does moving from patch to update fixes the issue then ?
There was a problem hiding this comment.
Yes DeepCopy is needed in case of a controller runtime patch because that's how the client.MergeFrom function works but still, I'm not sure why it fixes it, but I've seen it does
There was a problem hiding this comment.
I was advised by upstream to inverse the order of the delete and the patch, that's worth trying
There was a problem hiding this comment.
Testing here #32
|
After some discussions, we decided to remove the finalizers from the resource that this operator manages itself without relying on any other operator. |
|
Tested on grizzly. @TheoBrigitte do you want to take a look? |
|
No more issues on grizzly |
What this PR does / why we need it
Towards https://github.com/giantswarm/giantswarm/issues/30887
This PR fixes the finalizer removal. This has been tested on grizzly
Checklist