Fix sending invalid Alertmanager configuration #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoBrigitte
force-pushed
the
alertmanager-controller
branch
from
1b25e48 to
5ee639c
Compare
TheoBrigitte
commented
Dec 17, 2024
| @@ -46,6 +46,7 @@ func SetupAlertmanagerReconciler(mgr ctrl.Manager, conf config.Config) error { | |||
|
|
|||
| // Setup the controller | |||
| return ctrl.NewControllerManagedBy(mgr). | |||
| Named("alertmanager"). | |||
There was a problem hiding this comment.
Adding this otherwise the controller shows up as "secret" in the logs
QuentinBisson
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the Alertmanager configuration sent is invalid, due to using output from config.Load which does produce an invalid configuration with all secrets replaced with .
What this PR does / why we need it
Checklist