Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sso settings api instead of app user-values #203

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it

This is the first attempt to use the SSO settings api instead of the app platform to manage grafana sso settings

Checklist

  • Update changelog in CHANGELOG.md.
  • Follow deployment test procedure in the tests/manual_e2e directory and have a working branch.

@QuentinBisson QuentinBisson self-assigned this Dec 16, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner December 16, 2024 23:03
@QuentinBisson QuentinBisson force-pushed the use-sso-settings-api branch 3 times, most recently from 24a4b81 to 0c7b930 Compare December 17, 2024 08:45
pkg/grafana/sso_settings.go Outdated Show resolved Hide resolved
@hervenicol
Copy link
Contributor

I love it! 💟

  • no more taking over grafana-user-values
  • no more grafana restarts each time we add/remove an org
  • which means no more users getting disconnected each time we change orgs
  • faster application of orgs changes

Great! 👏

@QuentinBisson QuentinBisson merged commit 5f22fa6 into main Dec 17, 2024
8 of 9 checks passed
@QuentinBisson QuentinBisson deleted the use-sso-settings-api branch December 17, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants