Add Alertmanager controller #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add secret resource, embedding raw and templated alertmanager files - Expose alertmanager templates values as helm chart values - Remove all Mimir related conditions - Split template into url and notification templates - Drop template directive, dynamically set by the operator - Escape template in template - Re-use slack actions
…asepath from values inside tpl function
This fixes the infamous: error calling tpl: cannot retrieve Template.Basepath from values inside tpl function It does use .Values in templates to access values and pass $ root context to tpl
Co-authored-by: Quentin Bisson <[email protected]>
QuantumEnigmaa
approved these changes
Dec 16, 2024
|
Tested all 3 cases, when reconciliation should happen
|
| @@ -31,12 +31,15 @@ spec: | |||
| - --management-cluster-pipeline={{ $.Values.managementCluster.pipeline }} | |||
| - --management-cluster-region={{ $.Values.managementCluster.region }} | |||
| # Monitoring configuration | |||
| - --alertmanager-enabled={{ $.Values.alerting.enabled }} | |||
There was a problem hiding this comment.
I would move this under #alerting configuration but this can be done once all PRs are merged
There was a problem hiding this comment.
That's already under alerting
There was a problem hiding this comment.
I meant the comment 😉
QuentinBisson
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#3747
This PR adds the Alertmanager controller, which reconciles the Alertmanager secret created by the observability-operator Helm chart and load the configuration and templates from the secret into Mimir Alertmanager.
It also watches the Mimir Alertmanager pod and re-queue events to the controller when the pod is restarted, so the configuration is reloaded.