Remove label for old slo framework #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
Merged
|
Can you link the sloth rules covering the prometheus-operator availability ? |
|
Well no because it does not exist yet |
|
Does it mean we'll lost slo on prometheus-operator when we merge that PR ? |
|
When we release it into the bundle yes but we are not in a rush to release |
|
Ok do we have a ticket to create the sloth rules ? |
|
Yes here giantswarm/roadmap#3318 (comment) |
|
I don't like the idea of releasing kps and waiting to release o11y-bundle because we can forget to wait. I'd prefer synchronizing PR removing old slo and PR adding sloth rules. |
|
Sure sure |
|
@marieroque I still need an approval :D |
marieroque
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3318
This PR removes the label used by the old slo framework in order to get rid of the old slo framework.
This will be turned into an availability slo for the prometheus operator in sloth-rules https://github.com/giantswarm/sloth-rules/pull/186