Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mimir write mixin dashboard #438

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Add mimir write mixin dashboard #438

merged 7 commits into from
Feb 29, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Towards giantswarm/roadmap#3162

This PR adds the mimir mixin dashboards. Maybe they're all not needed, let's discuss about that

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@QuantumEnigmaa QuantumEnigmaa self-assigned this Feb 22, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner February 22, 2024 10:37
@QuentinBisson
Copy link
Contributor

Have you deployed them? Tested they work?

@QuantumEnigmaa
Copy link
Contributor Author

I'm currently doing it :)

@hervenicol
Copy link
Contributor

It would be nice to add a document explaining where these dashboards come from, and what you had to do to fix them.
Like here: https://github.com/giantswarm/dashboards/tree/master/loki

@QuantumEnigmaa
Copy link
Contributor Author

Some graph display interesting data but most of them will need to be adapted to our setup :
image
image

@QuentinBisson
Copy link
Contributor

Would you think it makes sense that we add them one by one ? Because we probably don't need them all, yet and also because fixing and screenshottig will bé easier

@QuantumEnigmaa QuantumEnigmaa changed the title Add mimir mixin dashboards Add mimir write mixin dashboard Feb 26, 2024
@QuentinBisson
Copy link
Contributor

Can you post a screenshot when it works?

@QuantumEnigmaa
Copy link
Contributor Author

This is what the dashboard looks like currently (at least the most interesting parts) :
image

image

On the second screenshot, one can have an overview of the regular cycles where the ingester uploads its data to the object storage.

@QuentinBisson
Copy link
Contributor

This is nice :)

Maybe we could reduce the interval between compactions :D

@QuentinBisson
Copy link
Contributor

Do you want to add the others in this PR ? If not,can you list hte dashboards we want to add in the parent issue?

@QuantumEnigmaa
Copy link
Contributor Author

Maybe we could reduce the interval between compactions :D

Yeah, but this is outside of the scope for this issue x)
But I agreee that if possible, it could be nice to reduce it to save on resources !

Do you want to add the others in this PR ? If not,can you list hte dashboards we want to add in the parent issue?

I will create other PRs for the other dashboards and I'll write those ones in the issue :)

@QuantumEnigmaa
Copy link
Contributor Author

Sorry, late change in plans : I'm also adding the writes-resources dashboard in this PR as it's write related 🙇

@QuentinBisson
Copy link
Contributor

Screenshot or it did not happen :)

@QuantumEnigmaa
Copy link
Contributor Author

Apart from the disk storage graphs (which I'm currently working on), we have nice data :
image

@QuantumEnigmaa QuantumEnigmaa enabled auto-merge (squash) February 29, 2024 15:05
@QuentinBisson
Copy link
Contributor

Should we add the networ dashboard here as well?

@QuantumEnigmaa QuantumEnigmaa merged commit 6287486 into master Feb 29, 2024
4 checks passed
@QuantumEnigmaa QuantumEnigmaa deleted the add-mimir-mixins branch February 29, 2024 15:06
@QuantumEnigmaa
Copy link
Contributor Author

Woops my bad sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants