-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate cluster-aws test pull requests #264
Conversation
/run cluster-test-suites Let's try this 🙈 |
/run cluster-test-suites |
/run cluster-test-suites |
/run cluster-test-suites |
1 similar comment
/run cluster-test-suites |
Closing to test of cluster-aws PR gets closed. |
There were no differences in the rendered Helm template. Output
|
Test pull request has been created in cluster-aws repo. Go to pull request giantswarm/cluster-aws#690 to test you cluster chart changes on AWS. |
There were no differences in the rendered Helm template. Output
|
Hey @nprokopic, a test pull request has been created for you in cluster-aws repo! Go to pull request giantswarm/cluster-aws#691 in order to test you cluster chart changes on AWS. |
Works nicely! 🎉 Will merge this to try it out for cluster chart PRs with actual cluster chart changes. We can then improve this and do the same for other providers (like CAPZ). |
What does this PR do?
This PR adds a GitHub workflow that automates creation of test PRs in cluster-aws in order to test cluster chart changes.
The workflow gets triggered for every cluster chart pull request. It has 2 jobs:
The job that creates/updates cluster-aws PRs will do the following (simplified steps):
test-cluster-chart-pr-{{ cluster chart PR number }}
. If the branch already existed it just checks out that branch.test-cluster-chart-pr-{{ cluster chart PR number }}
branch by setting it to a cluster chart version from the tested cluster chart PR.When cluster chart PR is closed, cluster-aws PR is closed as well.
What is the effect of this change to users?
Giant Swarm engineers can easily test provider-independent changes for CAPA.
Any background context you can provide?
CAPA is already GA, CAPZ will be GA soon, and all other providers will also soon start to use cluster chart, so without automated cross-provider testing the risk of issues slipping through cracks due to changes not being tested is very high.
Should this change be mentioned in the release notes?
No. This is CI change, no need to be included in the release notes.