Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max node pool name length #161

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Use max node pool name length #161

merged 1 commit into from
Dec 12, 2023

Conversation

fiunchinho
Copy link
Member

What this PR does

Towards https://github.com/giantswarm/giantswarm/issues/29041

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@fiunchinho
Copy link
Member Author

/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@fiunchinho
Copy link
Member Author

/run cluster-test-suites

@fiunchinho fiunchinho force-pushed the use-max-nodepool-name branch from 58455a7 to e8fcbb1 Compare December 12, 2023 11:08
@fiunchinho
Copy link
Member Author

/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@fiunchinho
Copy link
Member Author

All tests passed but eks. I'm re-running again to take a look.
/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@tinkerers-ci

This comment has been minimized.

@fiunchinho
Copy link
Member Author

Blocked until this is released giantswarm/cluster-eks#51

@fiunchinho fiunchinho marked this pull request as ready for review December 12, 2023 13:15
@fiunchinho fiunchinho requested review from a team as code owners December 12, 2023 13:15
@fiunchinho
Copy link
Member Author

/run cluster-test-suites

@fiunchinho fiunchinho enabled auto-merge (squash) December 12, 2023 13:36
@tinkerers-ci
Copy link

tinkerers-ci bot commented Dec 12, 2023

cluster-test-suites

Run name pr-cluster-test-suites-161-cluster-test-suitesxjt9h
Commit SHA e8fcbb1
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

@fiunchinho fiunchinho added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Dec 12, 2023
@fiunchinho fiunchinho merged commit 7bc61bf into main Dec 12, 2023
3 of 4 checks passed
@fiunchinho fiunchinho deleted the use-max-nodepool-name branch December 12, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants