Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include both schemas in values during migration #149

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

AverageMarcus
Copy link
Member

What this PR does

Includes both the old and new schema of cluster values to ensure the tests can still be run while the migration is underway.

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@AverageMarcus AverageMarcus requested review from a team as code owners December 4, 2023 07:47
@tinkerers-ci
Copy link

tinkerers-ci bot commented Dec 4, 2023

cluster-test-suites

Run name pr-cluster-test-suites-149-cluster-test-suitesx7xgj
Commit SHA 8bad48c
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

@AverageMarcus
Copy link
Member Author

The failing test is unrelated to this change and is a flakey cluster-autoscaler test that has been intermittently failing for a few runs now. Adding skip/ci label.

@AverageMarcus AverageMarcus added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Dec 4, 2023
@AverageMarcus AverageMarcus merged commit 6d98dea into main Dec 4, 2023
4 of 5 checks passed
@AverageMarcus AverageMarcus deleted the handle_migration branch December 4, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants