Make use of GetExpectedControlPlaneReplicas helper function #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Noble <[email protected]>
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: |
|
/run cluster-test-suites |
1 task
yulianedyalkova
approved these changes
Oct 6, 2023
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: |
|
/run cluster-test-suites |
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: |
|
CAPV seems to be having trouble provisioning clusters right now but is unrelated to this change so I'm going to skip CI as all the other providers passed. |
AverageMarcus
added
the
skip/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes the control plane node tests to make use of the new
GetExpectedControlPlaneReplicashelper function instead of trying to get the expected number of replicas from the Helm values as this is no longer possible with some providers.Fixes: https://github.com/giantswarm/giantswarm/issues/28262
Checklist
Trigger e2e tests
/run cluster-test-suites