Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timeouts to be more relevant #104

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update timeouts to be more relevant #104

merged 1 commit into from
Oct 5, 2023

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Oct 5, 2023

What this PR does

  • Updated clustertest to v0.9.0
  • Replaces all uses of DefaultTimeout with more appropriate and relevant timeouts.

Fixes: https://github.com/giantswarm/giantswarm/issues/28028

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@AverageMarcus AverageMarcus requested review from a team as code owners October 5, 2023 12:16
@AverageMarcus
Copy link
Member Author

🤦 I hadn't updated my branch. Re-triggering tests...

/run cluster-test-suites

@AverageMarcus AverageMarcus enabled auto-merge (squash) October 5, 2023 12:58
@tinkerers-ci
Copy link

tinkerers-ci bot commented Oct 5, 2023

cluster-test-suites

Run name pr-cluster-test-suites-104-cluster-test-suitesb68rd
Commit SHA 9b3405d
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

@AverageMarcus
Copy link
Member Author

One of the providers had a flake so I'm going to add the skip label as the rest passed as expected

@AverageMarcus AverageMarcus added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Oct 5, 2023
@AverageMarcus AverageMarcus merged commit ddb58f4 into main Oct 5, 2023
2 of 3 checks passed
@AverageMarcus AverageMarcus deleted the update_timeouts branch October 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants