Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsoci.azurecr.io/giantswarm/alpine Docker tag to v3.19 #922

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Update gsoci.azurecr.io/giantswarm/alpine Docker tag to v3.19 #922

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e756e16
Update gsoci.azurecr.io/giantswarm/alpine Docker tag to v3.19
renovate[bot] Jan 18, 2024
d827f2f
Find EXTERNALLY-MANAGED file
marians Jan 18, 2024
f3938be
Remove EXTERNALLY-MANAGED file
marians Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ FROM gsoci.azurecr.io/giantswarm/golang:1.21.6-alpine3.18 AS golang
FROM gsoci.azurecr.io/giantswarm/conftest:v0.48.0 AS conftest

# Build Image
FROM gsoci.azurecr.io/giantswarm/alpine:3.18
FROM gsoci.azurecr.io/giantswarm/alpine:3.19

# Copy go from golang image.
COPY --from=golang /usr/local/go /usr/local/go
Expand Down Expand Up @@ -57,6 +57,10 @@ RUN mkdir ~/.ssh &&\
printf "Host github.com\n IdentitiesOnly yes\n IdentityFile ~/.ssh/id_rsa\n" >> ~/.ssh/config &&\
chmod 600 ~/.ssh/*

# Allow installing python modules in the global context.
# See https://peps.python.org/pep-0668/
RUN rm -f /usr/lib/python3.11/EXTERNALLY-MANAGED

Comment on lines +60 to +63
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @piontec as this will probably become relevant in other Python projects, too, when moving to Alpine 3.19.

By default, installing dependencies into the global context is not allowed. To switch back to the old behaviour, the EXTERNALLY-MANAGED can be removed. The more canonical way would be to create an actual virtual environment for the modules needed.

RUN pip install yamllint==${CT_YAMLLINT_VER} yamale==${CT_YAMALE_VER}

ADD ./architect /usr/bin/architect
Expand Down