Remove windows support

gi0baro · Nov 17, 2024 · 391ef0d · 391ef0d
1 parent 8ec4d8f
commit 391ef0d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 50 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -37,7 +37,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu, macos, windows]
+        os: [ubuntu, macos]
         target: [x86_64, aarch64]
         manylinux: [auto]
         include:
@@ -66,20 +66,6 @@ jobs:
             platform: linux
             target: aarch64
             manylinux: musllinux_1_1
-          - os: windows
-            target: x86_64
-            interpreter: pypy3.9 pypy3.10
-        exclude:
-          - os: windows
-            target: aarch64
-          # PGO builds
-          # - os: ubuntu
-          #   target: x86_64
-          #   manylinux: auto
-          # - os: macos
-          #   target: x86_64
-          # - os: windows
-          #   target: x86_64
     steps:
       - uses: actions/checkout@v4
       - name: Set jemalloc for aarch64 Linux
@@ -107,7 +93,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-13, macos-14, windows-latest]
+        os: [ubuntu-latest, macos-13, macos-14]
         manylinux: [auto]
         interpreter: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         include:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -72,33 +72,3 @@ jobs:
       run: |
         source .venv/bin/activate
         make test
-
-  windows:
-    runs-on: windows-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        python-version:
-        - '3.9'
-        - '3.10'
-        - '3.11'
-        - '3.12'
-        - '3.13'
-
-    steps:
-    - uses: actions/checkout@v4
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
-      with:
-        python-version: ${{ matrix.python-version }}
-        allow-prereleases: true
-    - name: Install
-      run: |
-        python -m venv venv
-        venv/Scripts/Activate.ps1
-        pip install maturin==${{ env.MATURIN_VERSION }} pytest
-        maturin develop --extras=test
-    - name: Test
-      run: |
-        venv/Scripts/Activate.ps1
-        make test
diff --git a/pyproject.toml b/pyproject.toml
@@ -8,7 +8,6 @@ classifiers = [
     'Intended Audience :: Developers',
     'License :: OSI Approved :: BSD License',
     'Operating System :: MacOS',
-    'Operating System :: Microsoft :: Windows',
     'Operating System :: POSIX :: Linux',
     'Programming Language :: Python :: 3',
     'Programming Language :: Python :: 3.9',

diff --git a/src/io.rs b/src/io.rs
@@ -25,17 +25,18 @@ pub(crate) enum Source {
 #[derive(Debug)]
 pub struct SourceRawSocket<'a>(pub &'a RawSocket);
 
+// NOTE: this won't work as `selector()` is not exposed on win
 #[cfg(windows)]
 impl<'a> MioSource for SourceRawSocket<'a> {
-    fn register(&mut self, registry: &Registry, token: Token, interests: Interest) -> io::Result<()> {
+    fn register(&mut self, registry: &Registry, token: Token, interests: Interest) -> std::io::Result<()> {
         registry.selector().register(*self.0, token, interests)
     }
 
-    fn reregister(&mut self, registry: &Registry, token: Token, interests: Interest) -> io::Result<()> {
+    fn reregister(&mut self, registry: &Registry, token: Token, interests: Interest) -> std::io::Result<()> {
         registry.selector().reregister(*self.0, token, interests)
     }
 
-    fn deregister(&mut self, registry: &Registry) -> io::Result<()> {
+    fn deregister(&mut self, registry: &Registry) -> std::io::Result<()> {
         registry.selector().deregister(*self.0)
     }
 }