Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Bower Support / No need to compile library dependencies #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better Bower Support / No need to compile library dependencies #166

wants to merge 3 commits into from

Conversation

nmccready
Copy link

including dest and prebuilt js files

Please see this post with regards to bower standards.
http://stackoverflow.com/questions/17170500/how-make-bower-build-the-package

@ghusse
Copy link
Owner

ghusse commented Jun 1, 2014

Not sure that jquery-ui needs to be added to this dest directory.

@nmccready
Copy link
Author

Is there a reason it is there in the first place? I never changed anything to the grunt file. So whatever is in the dist/dest was there in the build processes originally.

@ghusse
Copy link
Owner

ghusse commented Jun 1, 2014

They're just here for the demo page, which is included in the package.

I can remove them, I probably will.

The problem of this bower support is that it uses git for storing minified versions of source files. And I do not want to do this. It's like requiring to store binary executables in the same place as source code in C (or whatever). I don't like the idea.

Plus, it's a pain to maintain.

Now, if you come with a better idea, I'll agree to consider it and support bower.

@nmccready
Copy link
Author

We can add whatever you want to ignore to the .gitignore and bower ignore list
As for bower requiring minefield js filese.. That is false. There no idea of maintenance as it is just compiled / generated file. People with grunt , gulp, rails .. Etc will minify the file themselves.

Let me know what should be in the ignore list.

Removing dest / dist files that are not a end product for bower .
@ghusse
Copy link
Owner

ghusse commented Jun 1, 2014

I don't completely get your point, but as I'm not an user of bower, if you
can propose a solution for supporting bower the good way, I'll be glad to
add it.
Le 1 juin 2014 22:42, "nmccready" [email protected] a écrit :

We can add whatever you want to ignore to the .gitignore and bower ignore
list
As for bower requiring minefield js filese.. That is false. There no idea
of maintenance as it is just compiled / generated file. People with grunt ,
gulp, rails .. Etc will minify the file themselves.

Let me know what should be in the ignore list.


Reply to this email directly or view it on GitHub
#166 (comment).

@nmccready
Copy link
Author

I just modified the .gitignore to not add non "end product" library files that are in the dest directory after a build. This way only what should be registered to be in bower is more to the point. I cleaned up the dest directory as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants