passing samples_padded by ref to the threads. #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 6, 2024 05:04
|
@ggerganov I tested this change, and it introduce a new memory leak, after |
Josscii
added a commit
to Josscii/whisper.cpp
that referenced
this pull request
Nov 10, 2024
This reverts commit 31aea56.
|
I don't see why it would cause more memory usage. |
adutilleul
pushed a commit
to adutilleul/whisper.cpp
that referenced
this pull request
Nov 19, 2024
* passing samples_padded by ref to the threads. * passing samples_padded by ref to the threads. --------- Co-authored-by: Vinith Misra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed substantial memory usage during multithreaded MFCC processing of large audio files. This appears to originate from copying the full
samples_paddedaudio sequence to each MFCC processing thread.This minor optimization switches to a cref to avoid copying. MFCC extraction doesn't modify the samples so I believe this is safe.