Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rationale for vendoring WebGPU bindings. #6381

Merged

Conversation

jimblandy
Copy link
Member

This commit is almost entirely autogenerated changes.

@jimblandy jimblandy requested a review from a team as a code owner October 8, 2024 01:35
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice writedown, thank you!

Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to mention that this also serves as a workaround for --cfg=web_sys_unstable_apis, which would be required when depending on unstable APIs in web-sys.

@jimblandy jimblandy force-pushed the vendoring-no-local-changes-for-you branch from c79717b to 7967013 Compare October 8, 2024 16:11
@jimblandy
Copy link
Member Author

It turns out that #5751 manually patched the vendored files, so my re-vendoring broke uses of GpuFeatureName::TextureCompressionBcSliced3d. I'm going to patch it back in manually to let this PR land, and then file a follow-up issue to remove it.

@mehmetoguzderin @teoxoy We can't generally have local changes to the files in wgpu/src/backend/webgpu/webgpu_sys, unfortunately.

@jimblandy jimblandy force-pushed the vendoring-no-local-changes-for-you branch from 7967013 to 8258c4d Compare October 8, 2024 16:43
This commit is almost entirely autogenerated changes.
@jimblandy jimblandy force-pushed the vendoring-no-local-changes-for-you branch from 8258c4d to e332ca5 Compare October 8, 2024 16:43
@jimblandy jimblandy enabled auto-merge (rebase) October 8, 2024 16:49
@jimblandy jimblandy merged commit 58e1946 into gfx-rs:trunk Oct 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants