chore: update deno #6068
Open
chore: update deno #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luca Casonato <[email protected]> Co-authored-by: Bartek Iwańczuk <[email protected]> Co-authored-by: chirsz <[email protected]> Co-authored-by: Hajime-san <[email protected]> Co-authored-by: Volker Schlecht <[email protected]>
Wumpf
reviewed
Aug 2, 2024
ErichDonGubler
approved these changes
Aug 12, 2024
| @@ -19,7 +19,7 @@ path = "lib.rs" | |||
| deno_core.workspace = true | |||
| serde = { workspace = true, features = ["derive"] } | |||
| tokio = { workspace = true, features = ["full"] } | |||
| wgpu-types = { workspace = true, features = ["serde"] } | |||
| wgt = { workspace = true, package = "wgpu-types", features = ["serde"] } | |||
There was a problem hiding this comment.
issue: I get this warning from cargo clippy with this change:
warning: <snip>/wgpu/deno_webgpu/Cargo.toml: unused manifest key: target.cfg(not(target_arch = "wasm32")).dependencies.wgt.package
Is this worth changing, since you just use wgt as wgpu_types anyway? :thonk:
|
@crowlKats: I think if you rebase, CI issues should go away. I've worked on the ones that were failing this PR, and we should try to get this merged! |
|
@ErichDonGubler yep, will do either tomorrow, or else will have to wait for the week after next |
|
any progress? I do not want to create more conflicts. |
# Conflicts: # Cargo.lock # Cargo.toml # deno_webgpu/buffer.rs # deno_webgpu/webgpu.idl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.