Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in create_render_pass #6041

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

matthew-wong1
Copy link
Contributor

@matthew-wong1 matthew-wong1 commented Jul 24, 2024

Description
Hi! I came across an error message in create_render_pass that mentions compute_pass instead of render_pass, which I think might be a mistake. I updated it to say render_pass instead.

Testing
Ran cargo xtask test

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@matthew-wong1 matthew-wong1 requested a review from a team as a code owner July 24, 2024 22:26
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) July 26, 2024 16:42
@ErichDonGubler ErichDonGubler merged commit 339ecf3 into gfx-rs:trunk Jul 26, 2024
25 checks passed
cwfitzgerald pushed a commit to cwfitzgerald/wgpu that referenced this pull request Jul 31, 2024
@Wumpf Wumpf removed the PR: needs back-porting PR with a fix that needs to land on crates label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants