Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #6033

Merged
merged 2 commits into from
Jul 24, 2024
Merged

chore: fix some comments #6033

merged 2 commits into from
Jul 24, 2024

Conversation

renshuncui
Copy link
Contributor

@renshuncui renshuncui commented Jul 24, 2024

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description

fix some comments

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Signed-off-by: renshuncui <[email protected]>
@renshuncui renshuncui requested review from a team as code owners July 24, 2024 13:30
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heeey, this is a great first contribution. LGTM, thanks! Welcome to the community. 🙂

@cwfitzgerald: Isn't typos supposed to catch at least some of these cases, i.e., exectue/execute? 🤔

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) July 24, 2024 13:47
@ErichDonGubler ErichDonGubler self-assigned this Jul 24, 2024
@ErichDonGubler
Copy link
Member

ErichDonGubler commented Jul 24, 2024

Just waiting on @gfx-rs/naga for a rubber stamp.

@waywardmonkeys
Copy link
Contributor

@cwfitzgerald: Isn't typos supposed to catch at least some of these cases, i.e., exectue/execute? 🤔

typos has a hardcoded list of typos that it looks for, so someone can submit the exectue one to them.

Unfortunately, preformed and trough are actual words, so we need the eagle-eyed readers to catch them. :)

@waywardmonkeys
Copy link
Contributor

I've submitted exectue upstream.

@ErichDonGubler ErichDonGubler merged commit 62333a5 into gfx-rs:trunk Jul 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants