Remove various unused fields in naga
#6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
naga
ErichDonGubler
force-pushed
the
push-uyuqntysxppy
branch
from
cdc2048 to
c37a475
Compare
ErichDonGubler
force-pushed
the
push-uyuqntysxppy
branch
from
c37a475 to
fbcf1ac
Compare
|
I'm not sure why CI doesn't catch this, but I see warnings for these unused fields consistently while running |
|
CI is running an older version of Rust (currently 1.76). |
teoxoy
reviewed
Jul 24, 2024
ErichDonGubler
force-pushed
the
push-uyuqntysxppy
branch
from
fbcf1ac to
6abce27
Compare
teoxoy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toCHANGELOG.md. See simple instructions inside file.