Require a compatible surface for request_adapter() on WebGL2
#5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
hal-surface
branch
3 times, most recently
from
7b6aece to
2389e8d
Compare
cwfitzgerald
approved these changes
Jul 3, 2024
|
Should this close #2343? |
|
Multiple surfaces will work more predictably but you still can't present to multiple surfaces via a single device (which I thought what #2343 was asking for, hence I renamed it). |
…apters()` on WebGL2 Also makes wgpu's `enumerate_adapters()` native only.
…Surface` and the `Adapter` don't share the same WebGL2 context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting WebGL2, it was always the case that a surface had to be created first before calling
request_adapter(). This PR makes it explicit that the adapter returned is compatible with the surface.Fixes #5190.
Adds validation to prevent #2343 (comment).