refactor: vertex_index_common: remove footguns in tests matrix init.
#5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual enumerations of various `enum`s with `derive`d ones via
`strum::{EnumIter, IntoEnumIterator}`.
…cartesian_product`
6 tasks
ErichDonGubler
added
area: infrastructure
nical
approved these changes
Jun 19, 2024
|
Sorry about the confusion - I didn't realize this PR was against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Addresses non-blocking feedback raised in #5773 (1, 2).
Description
Remove a couple of footguns around allocation and exhaustive matrices for tests using the
vertex_index_commonhelper.Testing
I've used
assert_eq!(…)checks between new and old values (not committed here) to ensure that we haven't regressed, so I feel fairly confident. 🙂 Attached:test.zipChecklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toNot necessary.CHANGELOG.md. See simple instructions inside file.