[naga] Remove ExpressionError::DoesntExist.
#5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `valid::expression::ExpressionError::DoesntExist`. This error is reported when expression validation encounters an invalid `Handle<Expression>`, but we have already verified that the module is free of invalid handles in `Validator::validate_module_handles`, so this condition should never arise.
Since `BlockContext::resolve_pointer_type` never returns an error, change its result type from a `Result` to a `&TypeInner`. Adjust callers accordingly. Remove calls (well, there's only one) to `resolve_pointer_type` entirely when the caller does not need the value, since `resolve_pointer_type` is now infallible and has no side effects.
jimblandy
added
area: validation
teoxoy
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
valid::expression::ExpressionError::DoesntExist. This error is reportedwhen expression validation encounters an invalid
Handle<Expression>, but wehave already verified that the module is free of invalid handles in
Validator::validate_module_handles, so this condition should never arise.Make
BlockContext::resolve_pointer_typeinfallible.Since
BlockContext::resolve_pointer_typenever returns an error,change its result type from a
Resultto a&TypeInner. Adjustcallers accordingly.
Remove calls (well, there's only one) to
resolve_pointer_typeentirely when the caller does not need the value, since
resolve_pointer_typeis now infallible and has no side effects.