Fix Color and Clear Problems on OpenGL Backend #1628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disabled writing to the alpha channel of the draw framebuffer. This fixes pixelated edges around the borders of the clear color. - Disable sRGB mode when creating the EGL surface. This was causing the color of the OpenGL backend to appear "washed-out" compared to the other backends.
zicklag
force-pushed
the
opengl-color-issues
branch
from
e484b3f to
2d7fc03
Compare
kvark
reviewed
Jul 11, 2021
| attributes.push(egl::GL_COLORSPACE as usize); | ||
| attributes.push(egl::GL_COLORSPACE_SRGB as usize); | ||
| } | ||
| // sRGB caused color problems, making the render lighter colored than the vulkan version |
There was a problem hiding this comment.
let's just remove this code entirely
| @@ -533,7 +533,7 @@ impl super::Queue { | |||
| 0, | |||
| ); | |||
| } | |||
| gl.color_mask(true, true, true, true); | |||
| gl.color_mask(true, true, true, false); | |||
There was a problem hiding this comment.
ok, this is certainly not the fix we want.
Isn't the shadow example outputting all alpha = 1 anyway?
This sounds like one of the following possibilities:
- alpha compositing mode is messed up, and we produce alpha that isn't 1.0
- driver bug
|
After investigation by @cwfitzgerald and testing summarized in my comment ( #1627 (comment) ) it seems like neither of these changes should actually be made and we need to find different ways around the issues so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes pixelated edges around the borders of the clear color.
color of the OpenGL backend to appear "washed-out" compared to the
other backends.
Connections
Fixes #1627
Description
Fixes some rendering differences between OpenGL and Vulkan backends on Linux:
Before:
After:
Testing
Tested on my Linux Pop!_OS ( Ubuntu ) 20.04 laptop using my "Mesa Intel(R) UHD Graphics (CML GT2)" adapter.
Extra info: