fix(core): handle HAL errors from query set creation (#6505)

* fix(core): handle HAL errors from query set creation * Update CHANGELOG.md Co-authored-by: Andreas Reich <[email protected]> --------- Co-authored-by: Andreas Reich <[email protected]>
gfx-rs · Nov 9, 2024 · 01973a9 · 01973a9
1 parent b89a57f
commit 01973a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -64,6 +64,10 @@ Bottom level categories:
 
 ### Bug Fixes
 
+#### General
+
+- Handle query set creation failure as an internal error that loses the `Device`, rather than panicking. By @ErichDonGubler in [#6505](https://github.com/gfx-rs/wgpu/pull/6505).
+
 #### Naga
 
 - Fix crash when a texture argument is missing. By @aedm in [#6486](https://github.com/gfx-rs/wgpu/pull/6486)

diff --git a/wgpu-core/src/device/resource.rs b/wgpu-core/src/device/resource.rs
@@ -3605,7 +3605,8 @@ impl Device {
 
         let hal_desc = desc.map_label(|label| label.to_hal(self.instance_flags));
 
-        let raw = unsafe { self.raw().create_query_set(&hal_desc).unwrap() };
+        let raw = unsafe { self.raw().create_query_set(&hal_desc) }
+            .map_err(|e| self.handle_hal_error(e))?;
 
         let query_set = QuerySet {
             raw: ManuallyDrop::new(raw),