Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump khronos-egl dependency to version 4 #3653

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

Aaron1011
Copy link
Contributor

This pulls in a fix for timothee-haudebourg/khronos-egl#14,
which prevents segfaults when using this crate from another thread
(e.g. gfx-rs/wgpu#246)

PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:
    • GL

This pulls in a fix for timothee-haudebourg/khronos-egl#14,
which prevents segfaults when using this crate from another thread
(e.g. gfx-rs/wgpu#246)
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 25, 2021

@bors bors bot merged commit 0a201d1 into gfx-rs:master Feb 25, 2021
Aaron1011 added a commit to Aaron1011/wgpu that referenced this pull request Feb 25, 2021
Fixes gfx-rs#246

Pulls in gfx-rs/gfx#3653,
which fixes a segfault when using wgpu from a non-main thread.
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Feb 26, 2021
1236: Update gfx to 0a201d1c406b5119ec11068293a40e50ec0be4c8 r=kvark a=Aaron1011

**Connections**
wgpu issue: #246
GFX PR: gfx-rs/gfx#3653
Underlying libloading issue: nagisa/rust_libloading#41

**Description**

Pulls in gfx-rs/gfx#3653,
which fixes a segfault when using wgpu from a non-main thread.

**Testing**

The example in #246 should run successfully. I'm not certain how to add an integration test to the repository.

Co-authored-by: Aaron Hill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants