Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk 2265 examples #354

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Sdk 2265 examples #354

merged 6 commits into from
Jun 18, 2024

Conversation

mehmet-yoti
Copy link
Contributor

No description provided.

@mehmet-yoti mehmet-yoti requested a review from saurabh-yoti June 13, 2024 15:41
Copy link

@saurabh-yoti saurabh-yoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share v2 (Digital Identity) works differently than Share v1.

Firstly, there are no Scenario IDs with this integration.

Secondly, we need to define a dynamic route in the example project to generate Sessions. This would only be an API route and doesn't need to render a HTML template. The routes that render HTML templates should be different from the API route. Please see examples in our other SDKs like Node or Go.

examples/digitalidentity/.env.example Outdated Show resolved Hide resolved
examples/digitalidentity/README.md Outdated Show resolved Hide resolved
examples/digitalidentity/README.md Outdated Show resolved Hide resolved
examples/digitalidentity/README.md Outdated Show resolved Hide resolved
examples/digitalidentity/README.md Show resolved Hide resolved
examples/digitalidentity/config/yoti.php Outdated Show resolved Hide resolved
@mehmet-yoti mehmet-yoti requested a review from saurabh-yoti June 18, 2024 10:13
@mehmet-yoti mehmet-yoti merged commit a6d34f6 into SDK-2265 Jun 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants