Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify removal of local packages #543

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

TraceyC77
Copy link
Contributor

Description

Add detail to the steps for clearing packages from the local repository.

@TraceyC77 TraceyC77 requested a review from davidjharder May 22, 2024 02:15
```bash
cd /var/lib/solbuild/local
sudo rm *.eopkg
sudo eopkg index --skip-signing /var/lib/solbuild/local/ --output /var/lib/solbuild/local/eopkg-index.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this is needed. build-local automatically re-indexes when used anyway.
Maybe it would be needed if you only removed some local packages, and then wanted to use the local repository for installation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, in the spirit of go-task commands I just learned: go-task build-localindex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I think it's safer to recommend re-indexing whenever someone removes eopkg files. It will help prevent someone's repo being in an unknown state if they come to us for help.
Good point about the go-task, I've updated the command to reflect that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also changed a couple of other manual commands to be go-task commands, thanks to ermo's reminder

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have go-task list-local (lists files in Local repo) and go-task clean-local (removes .eopkgs in local repo) tasks now, so those can be used instead for convenience.

@TraceyC77 TraceyC77 force-pushed the clarify_local_repo_cleaning branch from 9d36e66 to 22c3833 Compare November 10, 2024 20:51
Add detail to the steps for clearing packages from the local repository.
@TraceyC77 TraceyC77 force-pushed the clarify_local_repo_cleaning branch from 22c3833 to de1c91c Compare November 10, 2024 21:02
@TraceyC77 TraceyC77 self-assigned this Nov 10, 2024
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TraceyC77 TraceyC77 merged commit 466f0ad into master Nov 11, 2024
1 check passed
@TraceyC77 TraceyC77 deleted the clarify_local_repo_cleaning branch November 11, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants