Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devlog: Add post "Intro to optimizing packages on Solus" #485

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

joebonrichie
Copy link
Contributor

Description

New devlog post "Intro to Optimizing Packages on Solus" using libwebp as a storytelling device.

@joebonrichie joebonrichie force-pushed the devlog-optimizing-packages-intro branch from 8483f52 to ac27ec8 Compare February 9, 2024 14:19
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly nitpicked spelling and a little grammar. Writing style should not be nitpicked, IMO, for devlog posts

devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
@joebonrichie joebonrichie force-pushed the devlog-optimizing-packages-intro branch 2 times, most recently from e4bc4f9 to 6b35dbe Compare February 9, 2024 18:25
@joebonrichie joebonrichie force-pushed the devlog-optimizing-packages-intro branch from 6b35dbe to 6cf28ac Compare February 9, 2024 18:26
@joebonrichie joebonrichie marked this pull request as ready for review February 9, 2024 19:28
Copy link
Member

@Staudey Staudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David caught most of what I saw during my first read, just a few more tiny issues
(I'm also of the same opinion that writing style should be the one of the author for these kinds of posts and thus have not noted anything in this regard [also I happen to like this style ^^])

devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
devlog/2024-02-09-Intro-to-optimizing-packages-on-solus.md Outdated Show resolved Hide resolved
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, forgot to mark this approved (if that matters)

@joebonrichie joebonrichie merged commit 40db8e7 into master Feb 10, 2024
1 check passed
@joebonrichie joebonrichie deleted the devlog-optimizing-packages-intro branch February 10, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants