-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Desktop Background section #456
Conversation
Desktop Background section text updates based on Budgie 10.8.2, Solus 4.5
You can delete the old screenshots if they are not used anywhere else. An easy way to check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
…t-click.jpg Now-unused screenshot from old Budgie version
…ion.jpg Now-unused screenshot from old Budgie version
…ction.jpg Now-unused screenshot from old Budgie version
Hi - since I'm new to all of this I just wanted to check if this was correct - I ran the tool you mentioned for the three files that aren't needed on that page anymore, and they don't show up elsewhere, so I added deletions of those files to this pull request - let me know if that's OK? Thanks! (Included the last line below just to make sure the tool was working / I had correctly cloned the repository:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the comment I left on the general request probably should have gone here instead!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Yes, you understood my intent with the ripgrep
tool.
You don't need to have each deletion be it's own commit. You can group changes onto one commit since they're all part of the same pull request; and also I'm going to "squash" all your commits in this pull request into one larger commit anyway.
Thanks David - I think I need to read up a lot more on how to work with Git/GitHub! I realize what I'm sending is really messy, thanks for the help! |
No problem. It's definitely idiosyncratic, so don't worry if you find yourself scratching your head. Congrats on your first few PRs |
Description
Updates screenshots and instructions for changing desktop background to what I see in Budgie 10.8.2, Solus 4.5 - related to #131
Submitter Checklist
git rebase -i
(if needed)