Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Desktop Background section #456

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

johnandmegh
Copy link
Contributor

Description

Updates screenshots and instructions for changing desktop background to what I see in Budgie 10.8.2, Solus 4.5 - related to #131

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)

@davidjharder
Copy link
Member

You can delete the old screenshots if they are not used anywhere else.

An easy way to check:

  • Install ripgrep eopkg it ripgrep
  • From within the repository run rg "budgie-background-right-click.jpg"
  • This should spit back all the mentions of that file name within files

Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@johnandmegh
Copy link
Contributor Author

Hi - since I'm new to all of this I just wanted to check if this was correct - I ran the tool you mentioned for the three files that aren't needed on that page anymore, and they don't show up elsewhere, so I added deletions of those files to this pull request - let me know if that's OK?

Thanks! (Included the last line below just to make sure the tool was working / I had correctly cloned the repository:

johnkizer@boxes-solus ~/help-docs $ rg "budgie-background-section.jpg"
johnkizer@boxes-solus ~/help-docs $ rg "budgie-background-selection.jpg"
johnkizer@boxes-solus ~/help-docs $ rg "budgie-background-right-click.jpg"
johnkizer@boxes-solus ~/help-docs $ rg "budgie-desktop-blank-space-right-click.jpg"
docs/user/editions/budgie/configuration.md
234:![Budgie Desktop Right-Click Menu](configuration/budgie-desktop-blank-space-right-click.jpg)

Copy link
Contributor Author

@johnandmegh johnandmegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the comment I left on the general request probably should have gone here instead!

Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Yes, you understood my intent with the ripgrep tool.

You don't need to have each deletion be it's own commit. You can group changes onto one commit since they're all part of the same pull request; and also I'm going to "squash" all your commits in this pull request into one larger commit anyway.

@davidjharder davidjharder merged commit 8260652 into getsolus:master Jan 16, 2024
1 check passed
@johnandmegh johnandmegh deleted the patch-2 branch January 16, 2024 04:39
@johnandmegh
Copy link
Contributor Author

Thanks David - I think I need to read up a lot more on how to work with Git/GitHub! I realize what I'm sending is really messy, thanks for the help!

@davidjharder
Copy link
Member

No problem. It's definitely idiosyncratic, so don't worry if you find yourself scratching your head. Congrats on your first few PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants