fix(readjob): Pass readjob result as pointer

CHANGELOG.md

@@ -124,6 +124,7 @@
 - Lower number of concurrent reads ([#537](https://github.com/getsentry/vroom/pull/537))
 - Remove unused metrics summary kafka writer ([#538](https://github.com/getsentry/vroom/pull/538))
 - Remove unused chunks flamegraph endpoint ([#541](https://github.com/getsentry/vroom/pull/541))
+- Pass readjob result as pointer ([#542](https://github.com/getsentry/vroom/pull/542))
 
 ## 23.12.0
 

cmd/vroom/chunk.go

@@ -281,7 +281,7 @@ func (env *environment) postProfileFromChunkIDs(w http.ResponseWriter, r *http.R
 			// sense to have a final profile with missing chunks
 			continue
 		}
-		chunks = append(chunks, result.Chunk)
+		chunks = append(chunks, *result.Chunk)
 	}
 	s.Finish()
 	if err != nil {

internal/chunk/sample_readjob.go

@@ -25,7 +25,7 @@ type (
 
 	ReadJobResult struct {
 		Err           error
-		Chunk         Chunk
+		Chunk         *Chunk
 		TransactionID string
 		ThreadID      *string
 		Start         uint64
@@ -45,7 +45,7 @@ func (job ReadJob) Read() {
 
 	job.Result <- ReadJobResult{
 		Err:           err,
-		Chunk:         chunk,
+		Chunk:         &chunk,
 		TransactionID: job.TransactionID,
 		ThreadID:      job.ThreadID,
 		Start:         job.Start,
@@ -62,8 +62,8 @@ type (
 
 	CallTreesReadJobResult struct {
 		Err           error
-		CallTrees     map[string][]*nodetree.Node
-		Chunk         SampleChunk
+		CallTrees     *map[string][]*nodetree.Node
+		Chunk         *SampleChunk
 		TransactionID string
 		ThreadID      *string
 		Start         uint64
@@ -89,8 +89,8 @@ func (job CallTreesReadJob) Read() {
 
 	job.Result <- CallTreesReadJobResult{
 		Err:           err,
-		CallTrees:     callTrees,
-		Chunk:         chunk,
+		CallTrees:     &callTrees,
+		Chunk:         &chunk,
 		TransactionID: job.TransactionID,
 		ThreadID:      job.ThreadID,
 		Start:         job.Start,

internal/flamegraph/flamegraph.go

@@ -451,13 +451,13 @@ func GetFlamegraphFromCandidates(
 			example := utils.NewExampleFromProfileID(result.Profile.ProjectID(), result.Profile.ID())
 			annotate := annotateWithProfileExample(example)
 
-			for _, callTree := range result.CallTrees {
+			for _, callTree := range *result.CallTrees {
 				addCallTreeToFlamegraph(&flamegraphTree, callTree, annotate)
 			}
 			// if metrics aggregator is not null, while we're at it,
 			// compute the metrics as well
 			if ma != nil {
-				functions := metrics.CapAndFilterFunctions(metrics.ExtractFunctionsFromCallTrees(result.CallTrees), int(ma.MaxUniqueFunctions), true)
+				functions := metrics.CapAndFilterFunctions(metrics.ExtractFunctionsFromCallTrees(*result.CallTrees), int(ma.MaxUniqueFunctions), true)
 				ma.AddFunctions(functions, example)
 			}
 
@@ -466,7 +466,7 @@ func GetFlamegraphFromCandidates(
 			chunkProfileSpan := span.StartChild("calltree")
 			chunkProfileSpan.Description = "continuous profile"
 
-			for threadID, callTree := range result.CallTrees {
+			for threadID, callTree := range *result.CallTrees {
 				if result.Start > 0 && result.End > 0 {
 					interval := utils.Interval{
 						Start: result.Start,

internal/profile/readjob.go

@@ -20,7 +20,7 @@ type (
 
 	ReadJobResult struct {
 		Err     error
-		Profile Profile
+		Profile *Profile
 	}
 )
 
@@ -34,7 +34,7 @@ func (job ReadJob) Read() {
 		&profile,
 	)
 
-	job.Result <- ReadJobResult{Profile: profile, Err: err}
+	job.Result <- ReadJobResult{Profile: &profile, Err: err}
 }
 
 func (result ReadJobResult) Error() error {
@@ -46,8 +46,8 @@ type (
 
 	CallTreesReadJobResult struct {
 		Err       error
-		CallTrees map[uint64][]*nodetree.Node
-		Profile   Profile
+		CallTrees *map[uint64][]*nodetree.Node
+		Profile   *Profile
 	}
 )
 
@@ -69,8 +69,8 @@ func (job CallTreesReadJob) Read() {
 	callTrees, err := profile.CallTrees()
 
 	job.Result <- CallTreesReadJobResult{
-		CallTrees: callTrees,
-		Profile:   profile,
+		CallTrees: &callTrees,
+		Profile:   &profile,
 		Err:       err,
 	}
 }