Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Should write the profiler id #528

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Nov 7, 2024

When writing the id to the functions table, we should be using the profiler id not the chunk id. This means all the ids before this PR are actually all wrong.

When writing the id to the functions table, we should be using the profiler id
not the chunk id. This means all the ids before this PR are actually all wrong.
@Zylphrex Zylphrex requested a review from a team as a code owner November 7, 2024 21:32
@Zylphrex Zylphrex enabled auto-merge November 7, 2024 21:42
@Zylphrex Zylphrex merged commit 12e2352 into main Nov 7, 2024
12 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/should-write-the-profiler-id branch November 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants