Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flamegraph): Dispatch candidates using goroutine #513

Closed
wants to merge 3 commits into from

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Sep 4, 2024

By dispatching candidates using a goroutine, we can immediately start reading the results of the readjobs instead of waiting until all candidates have been dispatched.

By dispatching candidates using a goroutine, we can immediately start reading
the results of the readjobs instead of waiting until all candidates have been
dispatched.
@Zylphrex Zylphrex requested a review from a team as a code owner September 4, 2024 23:21
@Zylphrex
Copy link
Member Author

Zylphrex commented Sep 5, 2024

#512 seems to have had a significant enough impact that this doesn't look necessary anymore.

@Zylphrex Zylphrex closed this Sep 5, 2024
@Zylphrex Zylphrex deleted the txiao/fix/dispatch-candidates-using-goroutine branch September 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants