fix: make android samples monotonic #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timestamps (in this case just seconds) into a monotonic one
phacops
reviewed
Oct 17, 2023
@phacops I don't know if this can happen. |
I've changed the logic to convert This will take care of everything and it's more appropriate than treating them independently. |
Loop once, if the condition is detected then break and loop again starting from that index applying the logic to fix the time without checking the condition each time
phacops
reviewed
Oct 17, 2023
phacops
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wall-clock time is supposed to be monotonic. In a few rare cases we've noticed this was not the case.
Due to some overflow happening client-side in the embedded profiler, the sequence might be decreasing at certain points.
This is just a workaround to mitigate this issue (at rendering time) and avoid a front-end crash, should it happen.