feat: Use pipedreams to deploy #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgauntseo-sentry
suggested changes
Sep 13, 2023
…getsentry/vroom into pierre/use-pipedreams-to-deploy
|
@mattgauntseo-sentry Do we have a way to test this? Or maybe just merging, seeing if it works and reverting is fine with GoCD? |
|
The Validate GoCD Pipelines is the best test we have TBH - that action sends the generated pipeline to GoCD to see if it can accept the pipeline. There still can be some issues, but they tend to be more nuanced, and in those cases commiting and reverting is probably the easiest. |
mattgauntseo-sentry
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.