Merge pull request #409 from getsentry/txiao/chore/remove-unreleased-…

…regression-issue chore(stats-detectors): Remove unreleased regression issue
getsentry · Feb 12, 2024 · 5bc8cc9 · 5bc8cc9
2 parents 6ac4715 + ffd1f3d
commit 5bc8cc9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,7 @@
 - Bump trufflesecurity/trufflehog from 3.67.3 to 3.67.4 ([#406](https://github.com/getsentry/vroom/pull/406))
 - Bump trufflesecurity/trufflehog from 3.67.4 to 3.67.5 ([#407](https://github.com/getsentry/vroom/pull/407))
 - Bump golangci/golangci-lint-action from 3 to 4 ([#408](https://github.com/getsentry/vroom/pull/408))
+- Remove experimental function regression issue ([#409](https://github.com/getsentry/vroom/pull/409))
 
 ## 23.12.0
 

diff --git a/internal/occurrence/occurrence.go b/internal/occurrence/occurrence.go
@@ -219,12 +219,8 @@ func FromRegressedFunction(
 	beforeP95 := time.Duration(regressed.AggregateRange1).Round(10 * time.Microsecond)
 	afterP95 := time.Duration(regressed.AggregateRange2).Round(10 * time.Microsecond)
 
-	occurrenceType := FrameRegressionExpType
-	var issueTitle IssueTitle = "Function Duration Regression (Experimental)"
-	if regressed.Released {
-		occurrenceType = FrameRegressionType
-		issueTitle = "Function Regression"
-	}
+	occurrenceType := FrameRegressionType
+	var issueTitle IssueTitle = "Function Regression"
 
 	return &Occurrence{
 		Culprit:       fullyQualifiedName,

diff --git a/internal/occurrence/occurrence_test.go b/internal/occurrence/occurrence_test.go
@@ -64,28 +64,11 @@ func TestFromRegressedFunction(t *testing.T) {
 				Fingerprint:     0,
 				AggregateRange1: 100_000_000,
 				AggregateRange2: 200_000_000,
-				Released:        true,
 			},
 			expectedType:     2011,
 			expectedTitle:    "Function Regression",
 			expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
 		},
-		{
-			name:  "unreleased",
-			frame: f,
-			function: RegressedFunction{
-				OrganizationID:  1,
-				ProjectID:       1,
-				ProfileID:       "",
-				Fingerprint:     0,
-				AggregateRange1: 100_000_000,
-				AggregateRange2: 200_000_000,
-				Released:        false,
-			},
-			expectedType:     2010,
-			expectedTitle:    "Function Duration Regression (Experimental)",
-			expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
-		},
 	}
 
 	for _, tt := range tests {

diff --git a/internal/occurrence/regressed_frame.go b/internal/occurrence/regressed_frame.go
@@ -25,7 +25,6 @@ type RegressedFunction struct {
 	TrendPercentage          float64 `json:"trend_percentage"`
 	UnweightedPValue         float64 `json:"unweighted_p_value"`
 	UnweightedTValue         float64 `json:"unweighted_t_value"`
-	Released                 bool    `json:"released,omitempty"`
 }
 
 func ProcessRegressedFunction(