Skip to content

Commit

Permalink
chore(stats-detectors): Remove unreleased regression issue
Browse files Browse the repository at this point in the history
This was the experimental issue type. We can remove it now.
  • Loading branch information
Zylphrex committed Feb 9, 2024
1 parent fd3ced1 commit 2230fdf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 24 deletions.
8 changes: 2 additions & 6 deletions internal/occurrence/occurrence.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,8 @@ func FromRegressedFunction(
beforeP95 := time.Duration(regressed.AggregateRange1).Round(10 * time.Microsecond)
afterP95 := time.Duration(regressed.AggregateRange2).Round(10 * time.Microsecond)

occurrenceType := FrameRegressionExpType
var issueTitle IssueTitle = "Function Duration Regression (Experimental)"
if regressed.Released {
occurrenceType = FrameRegressionType
issueTitle = "Function Regression"
}
occurrenceType := FrameRegressionType
var issueTitle IssueTitle = "Function Regression"

return &Occurrence{
Culprit: fullyQualifiedName,
Expand Down
17 changes: 0 additions & 17 deletions internal/occurrence/occurrence_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,28 +64,11 @@ func TestFromRegressedFunction(t *testing.T) {
Fingerprint: 0,
AggregateRange1: 100_000_000,
AggregateRange2: 200_000_000,
Released: true,
},
expectedType: 2011,
expectedTitle: "Function Regression",
expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
},
{
name: "unreleased",
frame: f,
function: RegressedFunction{
OrganizationID: 1,
ProjectID: 1,
ProfileID: "",
Fingerprint: 0,
AggregateRange1: 100_000_000,
AggregateRange2: 200_000_000,
Released: false,
},
expectedType: 2010,
expectedTitle: "Function Duration Regression (Experimental)",
expectedSubtitle: "Duration increased from 100ms to 200ms (P95).",
},
}

for _, tt := range tests {
Expand Down
1 change: 0 additions & 1 deletion internal/occurrence/regressed_frame.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ type RegressedFunction struct {
TrendPercentage float64 `json:"trend_percentage"`
UnweightedPValue float64 `json:"unweighted_p_value"`
UnweightedTValue float64 `json:"unweighted_t_value"`
Released bool `json:"released,omitempty"`
}

func ProcessRegressedFunction(
Expand Down

0 comments on commit 2230fdf

Please sign in to comment.