fix: Rename frame drop issue title (#315)

getsentry · Sep 20, 2023 · 1cdbf56 · 1cdbf56
1 parent bad0bd5
commit 1cdbf56
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Internal**
+
+- Rename the frame drop issue title. ([#315](https://github.com/getsentry/vroom/pull/315))
+
 ## 23.9.1
 
 **Internal**

diff --git a/internal/occurrence/frame_drop_test.go b/internal/occurrence/frame_drop_test.go
@@ -161,11 +161,10 @@ func TestFindFrameDrop(t *testing.T) {
 						{Name: "Suspect function", Value: "child2", Important: true},
 						{Name: "Package", Value: "package"},
 					},
-					Fingerprint: []string{"8f2e4eaab20fd0a0acb48bb9bdd11b21"},
-					IssueTitle:  issueTitles[FrameDrop].IssueTitle,
-					Level:       "info",
-					Subtitle:    "child2",
-					Type:        issueTitles[FrameDrop].Type,
+					IssueTitle: issueTitles[FrameDrop].IssueTitle,
+					Level:      "info",
+					Subtitle:   "child2",
+					Type:       issueTitles[FrameDrop].Type,
 				},
 			},
 		},
@@ -384,9 +383,6 @@ func TestFindFrameDrop(t *testing.T) {
 						},
 						{Name: "Package", Value: "package"},
 					},
-					Fingerprint: []string{
-						"5f5584b142aab31b5f33b26884cdec56",
-					},
 					IssueTitle: issueTitles[FrameDrop].IssueTitle,
 					Level:      "info",
 					Subtitle:   "child2-1-1",
@@ -588,9 +584,6 @@ func TestFindFrameDrop(t *testing.T) {
 						},
 						{Name: "Package", Value: "package"},
 					},
-					Fingerprint: []string{
-						"1247dbde8be089556f3ae631f81e73c2",
-					},
 					IssueTitle: issueTitles[FrameDrop].IssueTitle,
 					Level:      "info",
 					Subtitle:   "child2-1",
@@ -759,9 +752,6 @@ func TestFindFrameDrop(t *testing.T) {
 						},
 						{Name: "Package", Value: "package"},
 					},
-					Fingerprint: []string{
-						"1247dbde8be089556f3ae631f81e73c2",
-					},
 					IssueTitle: issueTitles[FrameDrop].IssueTitle,
 					Level:      "info",
 					Subtitle:   "child2-1",
@@ -773,7 +763,7 @@ func TestFindFrameDrop(t *testing.T) {
 
 	options := cmp.Options{
 		cmpopts.IgnoreFields(Event{}, "ID"),
-		cmpopts.IgnoreFields(Occurrence{}, "DetectionTime", "ID"),
+		cmpopts.IgnoreFields(Occurrence{}, "DetectionTime", "ID", "Fingerprint"),
 		cmpopts.IgnoreUnexported(Occurrence{}),
 	}
 

diff --git a/internal/occurrence/occurrence.go b/internal/occurrence/occurrence.go
@@ -109,7 +109,7 @@ var issueTitles = map[Category]CategoryMetadata{
 	Decompression:    {IssueTitle: "Decompression on Main Thread"},
 	FileRead:         {IssueTitle: "File I/O on Main Thread"},
 	FileWrite:        {IssueTitle: "File I/O on Main Thread"},
-	FrameDrop:        {IssueTitle: "A Frame Drop Occurred", Type: FrameDropType},
+	FrameDrop:        {IssueTitle: "Frame Drop", Type: FrameDropType},
 	HTTP:             {IssueTitle: "Network I/O on Main Thread"},
 	ImageDecode:      {IssueTitle: "Image Decoding on Main Thread", Type: ImageDecodeType},
 	ImageEncode:      {IssueTitle: "Image Encoding on Main Thread"},