no need pointer on map

getsentry · Dec 6, 2024 · 13f6269 · 13f6269
1 parent 305c63b
commit 13f6269
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/internal/chunk/sample_readjob.go b/internal/chunk/sample_readjob.go
@@ -62,7 +62,7 @@ type (
 
 	CallTreesReadJobResult struct {
 		Err           error
-		CallTrees     *map[string][]*nodetree.Node
+		CallTrees     map[string][]*nodetree.Node
 		Chunk         *SampleChunk
 		TransactionID string
 		ThreadID      *string
@@ -89,7 +89,7 @@ func (job CallTreesReadJob) Read() {
 
 	job.Result <- CallTreesReadJobResult{
 		Err:           err,
-		CallTrees:     &callTrees,
+		CallTrees:     callTrees,
 		Chunk:         &chunk,
 		TransactionID: job.TransactionID,
 		ThreadID:      job.ThreadID,

diff --git a/internal/flamegraph/flamegraph.go b/internal/flamegraph/flamegraph.go
@@ -451,13 +451,13 @@ func GetFlamegraphFromCandidates(
 			example := utils.NewExampleFromProfileID(result.Profile.ProjectID(), result.Profile.ID())
 			annotate := annotateWithProfileExample(example)
 
-			for _, callTree := range *result.CallTrees {
+			for _, callTree := range result.CallTrees {
 				addCallTreeToFlamegraph(&flamegraphTree, callTree, annotate)
 			}
 			// if metrics aggregator is not null, while we're at it,
 			// compute the metrics as well
 			if ma != nil {
-				functions := metrics.CapAndFilterFunctions(metrics.ExtractFunctionsFromCallTrees(*result.CallTrees), int(ma.MaxUniqueFunctions), true)
+				functions := metrics.CapAndFilterFunctions(metrics.ExtractFunctionsFromCallTrees(result.CallTrees), int(ma.MaxUniqueFunctions), true)
 				ma.AddFunctions(functions, example)
 			}
 
@@ -466,7 +466,7 @@ func GetFlamegraphFromCandidates(
 			chunkProfileSpan := span.StartChild("calltree")
 			chunkProfileSpan.Description = "continuous profile"
 
-			for threadID, callTree := range *result.CallTrees {
+			for threadID, callTree := range result.CallTrees {
 				if result.Start > 0 && result.End > 0 {
 					interval := utils.Interval{
 						Start: result.Start,

diff --git a/internal/profile/readjob.go b/internal/profile/readjob.go
@@ -46,7 +46,7 @@ type (
 
 	CallTreesReadJobResult struct {
 		Err       error
-		CallTrees *map[uint64][]*nodetree.Node
+		CallTrees map[uint64][]*nodetree.Node
 		Profile   *Profile
 	}
 )
@@ -69,7 +69,7 @@ func (job CallTreesReadJob) Read() {
 	callTrees, err := profile.CallTrees()
 
 	job.Result <- CallTreesReadJobResult{
-		CallTrees: &callTrees,
+		CallTrees: callTrees,
 		Profile:   &profile,
 		Err:       err,
 	}