ref(metrics): Add support for the TOTALS clause in MetricsQuery #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `totals` parameter is true in the `Rollup` when an interval is specified, the query will set the `TOTALS True` clause on the SnQL query which will in turn use Clickhouse's WITH TOTALS clause to fetch an extra totals row.
volokluev
approved these changes
Oct 18, 2023
enochtangg
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
totalsparameter is true in theRollupwhen an interval isspecified, the query will set the
TOTALS Trueclause on the SnQL query whichwill in turn use Clickhouse's WITH TOTALS clause to fetch an extra totals row.