fix(dashboard): Cleanup DashboardProject instances on delete #80351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
narsaynorath
force-pushed
the
nar/fix/dashboards-cleanup-dashboardproject-relationships-on-delete
branch
from
27a8c68
to
795068b
Compare
Currently we leave a number of dashboard to project relationships hanging when projects are deleted. Add this clause so deleting projects removes them properly from the dashboard filters.
narsaynorath
force-pushed
the
nar/fix/dashboards-cleanup-dashboardproject-relationships-on-delete
branch
from
795068b
to
6de8c94
Compare
|
Closed this because I realized this is the default behaviour and the issues I'd seen for this were actually triggered from the filter conditions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we leave a number of dashboard to project relationships hanging when projects are deleted. Add this clause so deleting projects removes them properly from the dashboard filters.
This appeared because we were grabbing projects off the dashboard instances to run the widget queries, but if a project has been deleted, resolving the project could fail just to evaluate the filters.